Provide build settings for version-specific package manifests #1845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes swiftlang#1670 rdar://136014520
Member
Author
|
@swift-ci Please test |
hamishknight
approved these changes
Nov 25, 2024
| // (https://github.com/swiftlang/sourcekit-lsp/issues/1267) | ||
| for target in request.targets { | ||
| if target == .forPackageManifest { | ||
| let packageManifestName = #/^Package@swift-(\d+)(?:\.(\d+))?(?:\.(\d+))?.swift$/# |
Contributor
There was a problem hiding this comment.
Looks like this is copy-pasted from SwiftPM, but I should note that .swift should be \.swift here. Would it be worth exposing the regex (or an API that returns all the manifests) from SwiftPM to ensure this remains up-to-date?
Member
Author
There was a problem hiding this comment.
Yeah, I copied it. I think threading it through from SwiftPM will be tricky (SwiftPM uses its own RegEx type IIRC) and I don’t expect it to change. So, I think copying is the best solution we have right now. And then, I’d also copy the regex as it’s written in SwiftPM, including the issue that it should really be \.swift.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1670
rdar://136014520